rates/net/solver robustness tweaks/fixes - #1043
Open
Debraheem wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
work in progress.
(bugfix) Avoid double-counting composition residuals in the solver convergence norms.
Evaluate temperature corrections relative to the solver’s starting temperature.
Improve rate-table interpolation precision using a local quad-precision temperature coordinate.
Rewrite the seven reduced
approx21equilibrium links as paired net flows with consistent analytic derivatives.Add finite-difference regression tests for the grouped
approx21derivatives.Add a control for retry damping while retaining damping during relaxation.
Update the 20 solar-mass core-collapse test and standard models to exercise the new solver behavior in a fully coupled burn with gold tolerances on.